This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Arrays filling improvement and some tidy up. #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 24, 2016 02:49
jovilius
force-pushed
the
loops-semplification
branch
4 times, most recently
from
c6890e7
to
49f9bca
Compare
| @@ -66,8 +65,8 @@ case class CachingLookupAndAffineTransformDense[FV](numOutputs: Int, | |||
|
|
|||
| def activations(fv: Array[Int]) = { | |||
| val finalVector = DenseVector.zeros[Double](numOutputs) | |||
| for (i <- 0 until fv.size) { | |||
| // val wordPosn = fv(i) -> i | |||
| fv.indices.foreach { i => | |||
There was a problem hiding this comment.
i honestly would prefer for (i <- fv.indices) { here and elsewhere, but not enough to insist.
|
thanks for doing this! My biggest concern is with Array.fillWith (which should just be array.tabulate, anyway). A lot of places where I used a while loop is near an inner loop. |
jovilius
force-pushed
the
loops-semplification
branch
from
49f9bca
to
0669ac7
Compare
Merged
|
replaced by #51 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dlwh,
the goals of this PR are: