detect other os guest is a mismatch #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoetz
reviewed
Oct 16, 2019
Comment on lines
+28
to
+40
| selectors = { | ||
| architecture: architecture.name, | ||
| osfamily: operatingsystem.family, | ||
| name: operatingsystem.name, | ||
| major: operatingsystem.major.to_i | ||
| } | ||
|
|
||
| deduced_os = VsphereOsIdentifiers.find_by(selectors) | ||
| deduced_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major)) | ||
| deduced_os ||= VsphereOsIdentifiers.find_by(selectors.except(:release)) | ||
| deduced_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major, :release)) | ||
| deduced_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major, :name)) | ||
| deduced_os ||= VsphereOsIdentifiers.find_by(selectors.except(:major, :name, :release)) |
There was a problem hiding this comment.
Selector release does not exist anymore if I understand correctly. If it is ok, that it was removed lines 37, 38,40 are to be removed. If not it should be readded after line 32.
|
@timogoebel, @dgoetz what's the state here? Can I help testing this? |
|
I believe we need to re-think how we'd like to implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
Needs #93.