Skip to content

Commit

Permalink
Update ctr image pull all platforms
Browse files Browse the repository at this point in the history
Allows supporting fetching of all platforms while unpacking for a subset
of platforms.

Signed-off-by: Derek McGowan <derek@mcg.dev>
  • Loading branch information
dmcgowan committed May 10, 2024
1 parent b168147 commit 2788604
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions cmd/ctr/commands/images/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,20 @@ command. As part of this process, we do the following:
}

var sopts []image.StoreOpt
p, err := platforms.ParseAll(context.StringSlice("platform"))
if err != nil {
return err
}

// Set unpack configuration
for _, platform := range p {
sopts = append(sopts, image.WithUnpack(platform, context.String("snapshotter")))
}
if !context.Bool("all-platforms") {
p, err := platforms.ParseAll(context.StringSlice("platform"))
if err != nil {
return err
}
if len(p) == 0 {
p = append(p, platforms.DefaultSpec())
}
sopts = append(sopts, image.WithPlatforms(p...))

// Set unpack configuration
for _, platform := range p {
sopts = append(sopts, image.WithUnpack(platform, context.String("snapshotter")))
}
}
// TODO: Support unpack for all platforms..?
// Pass in a *?
Expand Down

0 comments on commit 2788604

Please sign in to comment.