Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fevals method must be used on controller.strategy #29

Closed
wants to merge 1 commit into from
Closed

Fix: fevals method must be used on controller.strategy #29

wants to merge 1 commit into from

Conversation

Ontahm
Copy link
Contributor

@Ontahm Ontahm commented Feb 26, 2019

controller.fevals >> controller.strategy.fevals

controller.fevals >> controller.strategy.fevals
@Ontahm
Copy link
Contributor Author

Ontahm commented Feb 26, 2019

After fixing #29 and #28 as suggested, the progress plot can be plotted without any problems.

@dme65
Copy link
Owner

dme65 commented May 8, 2019

Why is this change necessary? We don't want users to access the fevals through the strategy objects since the strategies aren't required to maintain a list of the records. This fevals should be accessed through the controller.

@Ontahm
Copy link
Contributor Author

Ontahm commented May 16, 2019

You are right.
I didn't really understand how POAP and the controller truly worked back then.
You can close/delete this issue as it is not a relevant one.

@dme65 dme65 closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants