Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cholesky exception handling in rbf #44

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

WY-Wang
Copy link
Contributor

@WY-Wang WY-Wang commented Sep 7, 2021

Hi! While reading the rbf.py, I noticed a typo in the exception handling of Cholesky factorization of the Schur complement, where the syntax "finally" should be corrected as "except". Due to such a typo, the proposed speed-up model update method doesn't work during algorithm iterations.

@dme65 dme65 merged commit c8f04fd into dme65:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants