Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS review] sample data needed #2

Closed
zingale opened this issue Nov 11, 2019 · 5 comments
Closed

[JOSS review] sample data needed #2

zingale opened this issue Nov 11, 2019 · 5 comments

Comments

@zingale
Copy link

zingale commented Nov 11, 2019

Is your feature request related to a problem? Please describe

The docs have a getting started section, but in order to play along, we need the sample data. The results of each step should be provided as well so we can verify the library is working as intended.

Describe the solution you'd like

sample dataset referenced in the docs should be included

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@zingale
Copy link
Author

zingale commented Nov 11, 2019

@dmentipl
Copy link
Owner

Hello @zingale, I've uploaded some sample Phantom data at: https://anaconda.org/dmentipl/example-phantom-data/files.

The data is from a simulation of a gas accretion disc with two sink particles, one representing the central star, and the other a planet. It includes:

  • two simulation snapshots as HDF5 files,
  • one text file with globally-averaged quantities,
  • two text files with sink particle quantities.

I have not yet done, but will add output to the documentation showing results of each step.

@dmentipl
Copy link
Owner

Hi @zingale, sorry for the slow response.

I've added to the documentation. And put up a more extensive data set to test at: https://anaconda.org/dmentipl/plonk_example_data.

@zingale
Copy link
Author

zingale commented Nov 23, 2019

thanks, that looks great. I'll try it out this weekend and then close this issue.

@zingale
Copy link
Author

zingale commented Nov 23, 2019

this works as expected.

@zingale zingale closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants