Replace reqwest with ureq #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agersant
commented
Dec 9, 2020
| @@ -194,7 +190,16 @@ impl LastFm { | |||
| params.insert("method".to_string(), operation.to_string()); | |||
| params.insert("api_sig".to_string(), signature); | |||
|
|
|||
| self.http_client.post(url).form(¶ms).send() | |||
| let params: Vec<(&str, &str)> = params | |||
There was a problem hiding this comment.
I though the HashMap<String, String> is more convenient to manipulate headers while crafting a request, so we only do this conversion at the last minute.
agersant
commented
Dec 9, 2020
| .collect(); | ||
|
|
||
| let resp = self.http_client.post(url).send_form(¶ms[..]); | ||
| match resp.synthetic_error() { |
There was a problem hiding this comment.
ureq always returns a response object, even when there is a transfer error (docs). This small check uncovers transfer errors masquerading as HTTP responses.
dmfutcher
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took significantly less effort than I expected 🥳
Addresses #47