[Doc] Evaluation Tutorial for Link Prediction #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
mufeili
reviewed
Nov 2, 2021
| @@ -218,8 +218,8 @@ def forward(self, g, h): | |||
|
|
|||
|
|
|||
| ###################################################################### | |||
| # Evaluating Performance (Optional) | |||
| # --------------------------------- | |||
There was a problem hiding this comment.
I feel this sentence needs improvement. ", where it treats the node embeddings learned by link prediction via training and evaluating a linear classifier on top of the learned node embeddings."
mufeili
reviewed
Nov 2, 2021
mufeili
reviewed
Nov 2, 2021
mufeili
reviewed
Nov 2, 2021
| ###################################################################### | ||
| # First you need to construct a graph for ``dgl.dataloading.EdgeDataLoader`` | ||
| # to iterate on, which should have the same nodes as the original | ||
| # ``graph``, but the testing node pairs as edges. You also need to |
There was a problem hiding this comment.
A natural question is then what if a user wants to apply a trained GNN to predict edges for a new graph with a different set of nodes?
There was a problem hiding this comment.
Extra empty space after "edges."
There was a problem hiding this comment.
Good suggestion. I rephrased it so I'm not emphasizing that the graph should be the same as original.
mufeili
reviewed
Nov 2, 2021
mufeili
approved these changes
Nov 2, 2021
|
Is there any problems in link-prediction-eval branch? |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a tutorial section for evaluating link prediction models on link prediction task.