[Feature] Compatibility to DLPack 0.6 in tensoradapter #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
yzh119
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
I noticed that PyTorch has made dlpack a part of the package:
https://github.com/pytorch/pytorch/blob/1a917e637c969de7e20c66227e689e007c9b2fc2/aten/src/ATen/dlpack.h
I wonder if it is possible to include dlpack from PyTorch instead of from our 3rd-party directory (which is usually not synced with PyTorch) for our torch backend?
I think it's not a big deal since the ABI did not change. |
|
@BarclayII When can I expect this PR being merged? |
BarclayII
added a commit
that referenced
this pull request
Mar 31, 2022
* compatibility to DLPack 0.6 in tensoradapter * fix * oops Co-authored-by: Jinjing Zhou <VoVAllen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make tensoradapter compilable against PyTorch 1.11, which upgrades DLPack to 0.6.0 that renamed a bunch of stuff.