Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] pass ntype/etype into partition book when node/edge_split #3828

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

Rhett-Ying
Copy link
Collaborator

Description

fix crash like IndexError: index out of range in self or Check failed: pid < machine_count

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 11, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@jermainewang
Copy link
Member

Why the ntype/etype is not required previously? Is it a mere bug or due to some recent changes?

@Rhett-Ying
Copy link
Collaborator Author

I think the bug exists for a long time. such logic(heterograph, force_even=False) is not covered in unit tests and user seldom use it as force_even is True in default.

@zheng-da zheng-da merged commit 480a4ae into dmlc:master Mar 14, 2022
@Rhett-Ying Rhett-Ying deleted the nodeSplit branch March 16, 2022 09:15
BarclayII pushed a commit that referenced this pull request Mar 31, 2022
…3828)

* [BugFix] pass ntype/etype into partition book when node/edge_split

* fix test failure

* fix test failue on mxnet

* fix test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants