-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance][Optimizer] Enable using UVA and FP16 with SparseAdamOptimizer #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
nv-dlasalle
force-pushed
the
uva_embedding
branch
from
March 30, 2022 21:49
553e25f
to
a8579c4
Compare
classicsong
reviewed
Apr 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
LTGM |
classicsong
approved these changes
Jun 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
The
I saw you've changed the |
yaox12
requested changes
Jun 21, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
yaox12
approved these changes
Jun 23, 2022
@nv-dlasalle If you don't have anything to add, I think it's OK to merge this PR. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
yaox12
force-pushed
the
uva_embedding
branch
2 times, most recently
from
June 23, 2022 14:24
44b4c98
to
b16bb40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables transferring optimizer states via UVA (by default) as well as storing them in FP16 (requires opt-in). While there are many factors, combining both of these optimizations improves performance in
backward
by about 2x and significantly cuts down on memory usage (both from FP16, and from not need allocate buffer tensors to copy to from the GPU).This depends on #3997 to ensure the UVA arrays get properly freed when the optimizer is destroyed.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
use_uva
anddtype
to the SparseAdamOptimizer.