Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] extend sort_csr/csc_by_tag to edge #4164

Merged
merged 9 commits into from
Jul 1, 2022

Conversation

Rhett-Ying
Copy link
Collaborator

Description

this feature is needed by the fix for sample_etype_neighbors in DistDGL: #4150.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 24, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@Rhett-Ying Rhett-Ying marked this pull request as draft June 24, 2022 04:04
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 24, 2022

Commit ID: 4dadbb8abe57c1f09866e42e38ab8c6a7ccf7480

Build ID: 1

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying marked this pull request as ready for review June 24, 2022 07:43
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 24, 2022

Commit ID: 2f30d80

Build ID: 2

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 24, 2022

Commit ID: 42b8cf9

Build ID: 3

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 24, 2022

Commit ID: 42b8cf9

Build ID: 4

Status: ❌ CI test failed in Stage [Tensorflow CPU Unit test].

Report path: link

Full logs path: link

python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
tests/compute/test_sort.py Outdated Show resolved Hide resolved
@jermainewang jermainewang added the Release Candidate Candidate PRs for the upcoming release label Jun 29, 2022
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2022

Commit ID: 9724d9ffa36c8c9c00c6e311061b27e05564d108

Build ID: 5

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2022

Commit ID: f334977

Build ID: 6

Status: ❌ CI test failed in Stage [Torch CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2022

Commit ID: f334977

Build ID: 7

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2022

Commit ID: 3900700

Build ID: 8

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
src/array/cpu/csr_sort.cc Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

Commit ID: 9bb2fe789a37e115f1cc2e49dae4dfe7df01ad18

Build ID: 9

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

Commit ID: d57a3aa1ec7d061ac98f511f24bfe9fb64aa7e60

Build ID: 10

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 1, 2022

Commit ID: 2413f86

Build ID: 11

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@jermainewang jermainewang merged commit 6a6597a into dmlc:master Jul 1, 2022
@Rhett-Ying Rhett-Ying deleted the distSortNeighborsByEtype branch July 1, 2022 05:16
@frozenbugs frozenbugs removed the Release Candidate Candidate PRs for the upcoming release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants