-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Unify the minimal versions required for PyTorch/TensorFlow/MXNet #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
yaox12
changed the title
[Doc] Unified the minimal versions required for PyTorch/TensorFlow/MXNet
[Doc] Unify the minimal versions required for PyTorch/TensorFlow/MXNet
Jun 28, 2022
jermainewang
approved these changes
Jun 28, 2022
@BarclayII Could you also take a look at this update? |
yaox12
force-pushed
the
fix_minimal_version
branch
from
June 28, 2022 07:46
3ea4fea
to
952b968
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Seems we need to upgrade TensorFlow to 2.3.0 in the CI docker images. cc @Rhett-Ying |
This comment was marked as outdated.
This comment was marked as outdated.
Rhett-Ying
reviewed
Jun 28, 2022
Rhett-Ying
reviewed
Jun 28, 2022
@jermainewang have we decided to add below version constraints ? If so, we need to update CI image and Jenkinsfile first so that this PR could test and pass.
|
Yes, please go ahead upgrade CI image. |
7 tasks
Rhett-Ying
reviewed
Jun 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves #4179 by unifying the minimal PyTorch/TensorFlow/MXNet versions we are supporting:
python/dgl/_dataloading/pytorch/dataloader.py
is legacy code so I leave it untouched.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change