Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Unify the minimal versions required for PyTorch/TensorFlow/MXNet #4180

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

yaox12
Copy link
Collaborator

@yaox12 yaox12 commented Jun 28, 2022

Description

This resolves #4179 by unifying the minimal PyTorch/TensorFlow/MXNet versions we are supporting:

  • PyTorch 1.9.0+
  • MXNet 1.6+
  • TensorFlow 2.3.0+

python/dgl/_dataloading/pytorch/dataloader.py is legacy code so I leave it untouched.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@yaox12 yaox12 requested a review from jermainewang June 28, 2022 07:14
@yaox12 yaox12 changed the title [Doc] Unified the minimal versions required for PyTorch/TensorFlow/MXNet [Doc] Unify the minimal versions required for PyTorch/TensorFlow/MXNet Jun 28, 2022
@jermainewang
Copy link
Member

@BarclayII Could you also take a look at this update?

@dgl-bot

This comment was marked as outdated.

@yaox12
Copy link
Collaborator Author

yaox12 commented Jun 28, 2022

Seems we need to upgrade TensorFlow to 2.3.0 in the CI docker images. cc @Rhett-Ying

@dgl-bot

This comment was marked as outdated.

@Rhett-Ying
Copy link
Collaborator

Rhett-Ying commented Jun 28, 2022

@jermainewang have we decided to add below version constraints ? If so, we need to update CI image and Jenkinsfile first so that this PR could test and pass.

PyTorch 1.9.0+
MXNet 1.6+
TensorFlow 2.3.0+

@jermainewang
Copy link
Member

Yes, please go ahead upgrade CI image.

@jermainewang jermainewang added the Release Candidate Candidate PRs for the upcoming release label Jun 29, 2022
@dgl-bot

This comment was marked as outdated.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2022

Commit ID: 2d41d50

Build ID: 4

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@yaox12 yaox12 merged commit 32f12ee into dmlc:master Jun 29, 2022
@yaox12 yaox12 deleted the fix_minimal_version branch June 29, 2022 10:37
@frozenbugs frozenbugs removed the Release Candidate Candidate PRs for the upcoming release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Unify the version requirements for PyTorch/TensorFlow/MXNet
5 participants