-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance] Redirect AllocWorkspace
to PyTorch's allocator if available
#4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
More backgrounds on PyTorch's CUDA allocator:
cc @nv-dlasalle |
nv-dlasalle
approved these changes
Jul 6, 2022
BarclayII
reviewed
Jul 7, 2022
BarclayII
approved these changes
Jul 7, 2022
I encountered the same issue as in #3933. Has the problem been resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #3933 #3957.
Redirect
AllocWorkspace/FreeWorkspace
to PyTorch's allocator viaraw_alloc
andraw_delete
.I run
examples/pytorch/graphsage/node_classification.py
and get the GPU memory footprints as:*The four columns on the right are reported by
torch.cuda.max_allocated/allocated/max_reserved/reserved
.The total GPU memory footprints are close. Advantages are:
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change