Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example][Fix] Fix CAREGNN example #4211

Merged
merged 5 commits into from
Jul 8, 2022
Merged

[Example][Fix] Fix CAREGNN example #4211

merged 5 commits into from
Jul 8, 2022

Conversation

yaox12
Copy link
Collaborator

@yaox12 yaox12 commented Jul 4, 2022

Description

Fix #4203. cc @chang-l

  1. Update CARESampler to meet the new sampling pipeline.
  2. Fix a bug when num_workers > 0.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@yaox12 yaox12 requested a review from BarclayII July 4, 2022 02:40
@dgl-bot

This comment was marked as outdated.

@jermainewang jermainewang added the Release Candidate Candidate PRs for the upcoming release label Jul 4, 2022
@dgl-bot

This comment was marked as outdated.

@dgl-bot

This comment was marked as outdated.

@yaox12 yaox12 requested a review from mufeili July 7, 2022 06:55
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2022

Commit ID: a0fd046

Build ID: 4

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 8, 2022

Commit ID: 65b552f

Build ID: 5

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@mufeili mufeili merged commit 3e26c3d into dmlc:master Jul 8, 2022
@yaox12 yaox12 deleted the fix_caregnn branch July 8, 2022 08:58
yaox12 added a commit to yaox12/dgl that referenced this pull request Jul 8, 2022
Co-authored-by: Mufei Li <mufeili1996@gmail.com>
BarclayII pushed a commit to BarclayII/dgl that referenced this pull request Aug 10, 2022
Co-authored-by: Mufei Li <mufeili1996@gmail.com>
@frozenbugs frozenbugs removed the Release Candidate Candidate PRs for the upcoming release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Example][Bug] Running error on the example case: example/pytorch/caregnn
5 participants