Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example][Bugfix] Fix dimenet example #4219

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

chang-l
Copy link
Collaborator

@chang-l chang-l commented Jul 6, 2022

Description

To fix #4204, the crash due to in-place operations for one variable needed for backward propagation.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

Disable grad calculation when reset frequencies.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 6, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 6, 2022

Commit ID: 1ec024a

Build ID: 1

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2022

Commit ID: 82e4e86

Build ID: 2

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

Copy link
Member

@mufeili mufeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@yaox12 yaox12 added the Release Candidate Candidate PRs for the upcoming release label Jul 7, 2022
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2022

Commit ID: 934f894

Build ID: 3

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2022

Commit ID: c9fe668

Build ID: 4

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@yaox12 yaox12 merged commit 28b0904 into dmlc:master Jul 7, 2022
@chang-l chang-l deleted the fix-example-dimenet branch July 7, 2022 07:27
BarclayII pushed a commit to BarclayII/dgl that referenced this pull request Aug 10, 2022
Co-authored-by: Xin Yao <xiny@nvidia.com>
@frozenbugs frozenbugs removed the Release Candidate Candidate PRs for the upcoming release label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Example][Bug] Running error on the example case: example/pytorch/dimenet
5 participants