Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] fix ffi docs #4248

Merged
merged 3 commits into from
Jul 14, 2022
Merged

[Docs] fix ffi docs #4248

merged 3 commits into from
Jul 14, 2022

Conversation

Zhanghyi
Copy link
Contributor

Description

I'm following ffi docs to implement CAPI in dgl. However, without the line I added, it will report DGLArgs and DGLRetValue's definitions are not found.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 13, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 13, 2022

Commit ID: 79b33a3e6b5055003bcb6db219565db0a8c3787e

Build ID: 1

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 13, 2022

Commit ID: 67acf25

Build ID: 2

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@jermainewang
Copy link
Member

Nice catch. Thanks for the fix!

@jermainewang jermainewang merged commit 5c76e47 into dmlc:master Jul 14, 2022
BarclayII pushed a commit to BarclayII/dgl that referenced this pull request Aug 10, 2022
Co-authored-by: Minjie Wang <wmjlyjemaine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants