[Bug] Revert clearing backward cache for retain_graph flag #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
|
The problem also did not appear in 1.9.1. I think we are good. |
jermainewang
approved these changes
Jul 14, 2022
BarclayII
added a commit
to BarclayII/dgl
that referenced
this pull request
Aug 10, 2022
Co-authored-by: Minjie Wang <wmjlyjemaine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is introduced in #3386 where it aims to resolve memory leaks for certain PyTorch versions (1.8.1 at that time; see #3230 and #3365). The fix however introduced new problems where
retain_graph=Trueduring backward is broken (see #4078). I reverted this PR and found that the memory leak no longer appears in at least PyTorch 1.11.0 and 1.12.0.