[Bug] Record stream when using another CUDA stream for data transfer #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Is the change required for a specific PyTorch version? Will it break other versions? |
|
The semantic seems to appear in at least 1.9.0. I think it's OK if we target 1.9.0+. |
No. |
BarclayII
approved these changes
Jul 14, 2022
|
Do we have unit tests for this feature? |
BarclayII
pushed a commit
to BarclayII/dgl
that referenced
this pull request
Aug 10, 2022
…mlc#4250) * record stream when using another cuda stream for data transfer * fix linting * fix None stream
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix #4247. pytorch/pytorch#23729 explains why we need
.record_stream().Known issue:
Subgraph transfer will be in the default stream because
dgl.heterographdoesn't support.record_stream()for now. If we are going to make it, we have to port.record_stream()via tensoradaptor for NDArrays allocated by PyTorch.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change