-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Refactor sampling #7367
[GraphBolt] Refactor sampling #7367
Conversation
To trigger regression tests:
|
How did the MSVC bug get resolved? |
Depends on #7369. |
@RamonZhou can you merge latest changes by updating branch and test the hetero example? |
@mfbalin I tested hetero_rgcn (CPU) on my local machine and it goes from 248.9s to 235.1s (per epoch), 5.5% improvement. |
That is because no GPU is there for forward backward. More improvement is expected when forward backward runs on the GPU. Cool, good work overall! |
Description
Refactor NeighborSampling and TemporalNeighborSampling.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes