Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Refactor sampling #7367

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

RamonZhou
Copy link
Collaborator

Description

Refactor NeighborSampling and TemporalNeighborSampling.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 28, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 28, 2024

Commit ID: d16ed9c

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@RamonZhou RamonZhou marked this pull request as ready for review April 28, 2024 08:46
@mfbalin
Copy link
Collaborator

mfbalin commented Apr 28, 2024

How did the MSVC bug get resolved?

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 28, 2024

Depends on #7369.

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 29, 2024

@RamonZhou can you merge latest changes by updating branch and test the hetero example?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 29, 2024

Commit ID: 8a880c2

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@RamonZhou
Copy link
Collaborator Author

RamonZhou commented Apr 29, 2024

@RamonZhou can you merge latest changes by updating branch and test the hetero example?

@mfbalin I tested hetero_rgcn (CPU) on my local machine and it goes from 248.9s to 235.1s (per epoch), 5.5% improvement.

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 29, 2024

@RamonZhou can you merge latest changes by updating branch and test the hetero example?

@mfbalin I tested hetero_rgcn (CPU) on my local machine and it goes from 248.9s to 235.1s (per epoch), 5.5% improvement.

That is because no GPU is there for forward backward. More improvement is expected when forward backward runs on the GPU. Cool, good work overall!

@RamonZhou RamonZhou merged commit f0213d2 into dmlc:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants