Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix parameter share regex #1267

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Fix parameter share regex #1267

merged 1 commit into from
Jul 17, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jul 17, 2020

As pointed out in #1261 (review)

@szha szha requested a review from sxjscience July 17, 2020 00:38
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #1267 into numpy will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##            numpy    #1267   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files          38       38           
  Lines        5446     5446           
=======================================
  Hits         4495     4495           
  Misses        951      951           
Impacted Files Coverage Δ
src/gluonnlp/models/transformer_xl.py 82.71% <33.33%> (ø)

@sxjscience sxjscience merged commit 9d83fe6 into dmlc:numpy Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants