-
Notifications
You must be signed in to change notification settings - Fork 538
Conversation
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html |
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 53 53
Lines 6987 6987
=======================================
Hits 5975 5975
Misses 1012 1012 Continue to review full report at Codecov.
|
let's rely on the website preview for making sure the logo is of the correct size |
Actually, can we make it smaller? |
@sxjscience do you mean with more padding? |
Yes, more padding.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Sheng Zha <notifications@github.com>
Sent: Thursday, December 3, 2020 1:35:04 PM
To: dmlc/gluon-nlp <gluon-nlp@noreply.github.com>
Cc: Xingjian SHI <xshiab@connect.ust.hk>; Mention <mention@noreply.github.com>
Subject: Re: [dmlc/gluon-nlp] [WEBSITE] adjust logo size (#1450)
@sxjscience<https://github.com/sxjscience> do you mean with more padding?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1450 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHQH3X3BFYPLWZJGCTCTSLSTAAARANCNFSM4ULNPL7Q>.
|
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html |
looks like we still need a bit more padding on the top? |
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html |
@sxjscience looks like some pyarrow-based datasets failed their tests. perhaps the data source has expired. |
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html |
Description
adjust logo size to reduce the margin
Checklist
Essentials
Changes
cc @dmlc/gluon-nlp-team