Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[WEBSITE] adjust logo size #1450

Merged
merged 3 commits into from
Dec 8, 2020
Merged

[WEBSITE] adjust logo size #1450

merged 3 commits into from
Dec 8, 2020

Conversation

szha
Copy link
Member

@szha szha commented Dec 3, 2020

Description

adjust logo size to reduce the margin

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • adjust logo size

cc @dmlc/gluon-nlp-team

@szha szha requested a review from a team as a code owner December 3, 2020 04:26
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1450 (f3f1dd9) into master (c6db365) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          53       53           
  Lines        6987     6987           
=======================================
  Hits         5975     5975           
  Misses       1012     1012           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6db365...f3f1dd9. Read the comment docs.

@szha
Copy link
Member Author

szha commented Dec 3, 2020

let's rely on the website preview for making sure the logo is of the correct size

@sxjscience
Copy link
Member

Actually, can we make it smaller?

@szha
Copy link
Member Author

szha commented Dec 3, 2020

@sxjscience do you mean with more padding?

@sxjscience
Copy link
Member

sxjscience commented Dec 3, 2020 via email

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

@szha
Copy link
Member Author

szha commented Dec 3, 2020

looks like we still need a bit more padding on the top?

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

@szha
Copy link
Member Author

szha commented Dec 7, 2020

@sxjscience looks like some pyarrow-based datasets failed their tests. perhaps the data source has expired.

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

@szha szha merged commit 33b6218 into dmlc:master Dec 8, 2020
@szha szha deleted the logo_size branch December 8, 2020 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants