[WIP] autocompletion

[ZihengJiang]

WIP

[jermainewang]

Can we directly use setattr in the init function to directly put them in the module object? I think this will save us another indirect call and it will automatically be added to dir.

[jermainewang]

Similar to https://github.com/dmlc/mxnet/blob/master/python/mxnet/ndarray.py#L1302

[ZihengJiang]

good idea! @jermainewang

[jermainewang]

Does auto-completion require function signature? If so, our PrimitiveSelector will break it.

[jermainewang]

LGTM

[lryta]

This PR fails Travis check.

[ZihengJiang]

Could you paste the Travis log link?

[lryta]

You can check the status of Travis. I fired a patch.

[ZihengJiang]

alright, I see, due to this method make the attributes fixed when initialize modules, but sometimes we need to change policy during runtime. Thank you!

[ZihengJiang]

I think this problem can be addressed by two different ways:

• revert this pr, return attributes by defined __dir__, every time change the policy should change the keys the __dir__ returns.
• continue using setattrs, but every time change the policy should reset modules' attributes

what's your opinion? @jermainewang @lryta

[jermainewang]

Could you completely disallow changing policies in the runtime? I guess this is what we want to push?

[ZihengJiang]

sounds good

[jermainewang]

Let's move the discussion to #93