-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all objectives currently supported by LightGBM #215
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #215 +/- ##
==============================================
- Coverage 83.55% 83.52% -0.04%
- Complexity 44 46 +2
==============================================
Files 92 92
Lines 6664 6700 +36
Branches 42 50 +8
==============================================
+ Hits 5568 5596 +28
- Misses 1072 1079 +7
- Partials 24 25 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one typo, but besides that I think we're good to go.
Co-authored-by: William Hicks <wphicks@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@wphicks Thanks for reviewing! |
Add all objectives currently supported by LightGBM. Notably, all regression objectives now offers an option
sqrt
. If this option is set, then the final output is given byf(x) = sign(x) * x**2
wherex
is the margin score.Closes #94
Closes #98