Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND][MXNET] Fix L2normalization error when run ssd model #1527

Closed
wants to merge 949 commits into from
Closed

[FRONTEND][MXNET] Fix L2normalization error when run ssd model #1527

wants to merge 949 commits into from

Conversation

ndcuong91
Copy link

This PR fix error L2Normalization when run ssd models from MXNET frontend. I also faced another error when run it with target openCL as described here https://github.com/dmlc/tvm/issues/1302. For short term solution, i reduced num_thread_x = 8 (line 307) and ofactor = 4 (line 309) in topi/python/topi/cuda/conv2d_nchw.py and i could run my ssd model successfully. How about long term solution for this issue?

eric-haibin-lin and others added 30 commits June 10, 2018 20:49
@eric-haibin-lin @tqchen
Update layout.h (apache#1255)
fed3b3d
@tqchen
[BUILD] Switch to CMake only Infra (apache#1254)
6207264
@tqchen
[BUILD] Upgrade build system to default python3 (apache#1260)
67dcc89
@tqchen
Fix the gemm conversion in onnx frontend (apache#1241)
66fab7e
@tqchen
Community guideline in effect (apache#1261)
eb2abb4
@tqchen
Update README.md
3574c20
@tqchen
[DOCS] Fix links (apache#1263)
dcdec18
@tqchen
Add Item list to community guide (apache#1264)
790b015
@tqchen
Update code_review.rst
0ef93dc
@tqchen
Fix the building error in android_deploy (apache#1262)
aed5ecd 
* Fix a link in android_deploy/README.md and a error while building android_deploy.

* revert and change APP_STL in Application.mk
@tqchen
[MAINTAINER] Add Pariksheet Pinjari as reviewer (apache#1266)
11f737f
@tqchen
[INTRIN] Add support for floor and ceil (apache#1267)
3160f5f
@tqchen
[CODEGEN] ARM Popcount lowering rule and codegen updates (apache#1235)
be29ac7
@zheng-da @piiswrong
add support for subgraphs. (apache#1221)
142c7da 
* add support for subgraphs.

* fix.

* fix.

* Fix compilation error

* Fix compilation error

* add comments.

* update comments.

* Sanity check on subgraphs when creating IndexedGraph

* avoid the overhead of sanity check.

* Stop using non-recursive DFS

* Trigger CI

* trigger CI
@merrymercy @tqchen
Add silent mode to rpc server and rpc tracker (apache#1268)
616580f
@tqchen
[BUILD] Enable path option for ROCM, CUDA, Vulkan, simplify optional …
d1530ec 
…build (apache#1270)
@srkreddy1238 @tqchen
[NNVM][FRONTEND] Tensorflow frontend support (apache#1188)
61d5303
@tqchen
[BUILD] Add clang to build matrix, -Werror (apache#1273)
d8faa50
@libing4752 @tqchen
fix copro_sync.cc errors of ctx (apache#1274)
4c40cb0
@eqy @tqchen
fix missing std::to_string during Android build, android rpc test scr…
86b063f 
…ipt (apache#1279)
@tqchen
[MAINTAINER] add masahi as reviewer (apache#1277)
7a43f44
@srkreddy1238 @tqchen
[TOPI][IMAGE][RESIZE] Bilinear interpolation for resize and upsamplin…
57f9588 
…g. (apache#1181)
@tqchen
Fix missing cublas libraries (apache#1281)
33f320b
@kazum @tqchen
Use CMake for make clean (apache#1280)
56e12f2
@kazum @tqchen
Remove incorrect extension registration of tvm::Target (apache#1272)
2f2f60f
@kazum @tqchen
Link system library needed for LLVM (apache#1282)
cff2382
@eqy @tqchen
fix proxy registration with tracker (apache#1283)
d83514b
@eqy @tqchen
fix lint (apache#1284)
1b8ff39
@kevinthesun @tqchen
SSD support in NNVM (apache#1214)
6ab4da6
@tqchen
[MAINTAINER] Add zhreshold as reviewer (apache#1287)
51836ba
@kaishijeng
Copy link

@kevinthesun

@kevinthesun
Copy link
Contributor

kevinthesun commented Aug 2, 2018 •
edited
Loading

@kaishijeng Yes. L2Normlization is required for gluoncv ssd implementation: https://github.com/dmlc/gluon-cv/blob/master/gluoncv/model_zoo/ssd/ssd.py I plan to support deploying these models in the next few weeks.

@kaishijeng
Copy link

@kevinthesun

Do you plan to support OpenCL for mobilenet ssd?

Thanks,

@yzhliu
Copy link
Member

yzhliu commented Aug 6, 2018

Please rebase according to #1394
Sorry for the inconvience

@kevinthesun
Copy link
Contributor

@kaishijeng I think @Laurawly is working for OpenCL SSD support.

@yzhliu yzhliu added the status: need update need update based on feedbacks label Aug 13, 2018
@yzhliu
Copy link
Member

yzhliu commented Aug 13, 2018

@titikid Could you update the status? wondering whether @Laurawly 's recent work fixes problems #1578

@ndcuong91 ndcuong91 requested a review from yzhliu as a code owner August 15, 2018 04:45
@ndcuong91
Copy link
Author

@yzhliu i updated l2_normalize's implementation with test cases. Plz help me review it. Thanks!

@yzhliu
Copy link
Member

yzhliu commented Aug 16, 2018

@titikid need to rebase according to #1394 . currently the PR has too many unrelated stuffs to review. Sorry for the inconvenience.

@ndcuong91
Copy link
Author

@yzhliu sorry. I got some issues when rebasing. May i make another PR?

@ndcuong91 ndcuong91 closed this Aug 20, 2018
@kaishijeng
Copy link

@kevinthesun

Any progress of gluoncv ssd implementation: ?

Thanks,

@kevinthesun
Copy link
Contributor

gluoncv ssd will be supported through hybrid frontend. It is delayed due to some limitation of hybrid frontend.

@madhavajay
Copy link

@kevinthesun Anything that we can help with?

@kaishijeng
Copy link

@kevinthesun

Any progress on this?

Thanks,

@kaishijeng
Copy link

@titikid @kevinthesun

Does current TVM code support mobilenet-ssd yet?

Thanks,

@kevinthesun
Copy link
Contributor

kevinthesun commented Dec 2, 2018 •
edited
Loading

Have you tried mxnet_ssd model? I think that should be supported now. Gluoncv models are in progress.

@kaishijeng
Copy link

Does it have mobilenet_ssd?
Thanks,

@kevinthesun
Copy link
Contributor

https://github.com/zhreshold/mxnet-ssd contains mobilenet ssd.

@kaishijeng
Copy link

I am not able to run deploy_ssd.py successfully. So I don't think I can try mobilenet_ssd using deploy_ssd.py

Thanks,

@kevinthesun
Copy link
Contributor

You can file a issue on discuss forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PariksheetPinjari909 PariksheetPinjari909 PariksheetPinjari909 requested changes

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees
No one assigned
Labels
status: need update need update based on feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.