Use latest cmake for clang-tidy. #10730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hcho3 I haven't updated clang-tidy itself on the CI yet, but I have run |
trivialfis
commented
Aug 21, 2024
| @@ -223,6 +222,14 @@ class JsonObject : public Value { | |||
| ~JsonObject() override = default; | |||
| }; | |||
|
|
|||
| namespace detail { | |||
| template <typename T, typename U> | |||
| using IsSameT = std::enable_if_t<std::is_same_v<std::remove_cv_t<T>, std::remove_cv_t<U>>>; | |||
There was a problem hiding this comment.
Only extracting this due to a potential bug in clang-tidy-19, can't be sure yet. It keeps asking me to use modernized type traits if I don't add these helpers, even though I have already been using the _v/t version.
1 task
Yes, that would be great. |
|
@hcho3 Done. |
hcho3
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cmake is required by the latest GPU tree shap.