Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary warning when 'gblinear' is selected #3888

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Remove unnecessary warning when 'gblinear' is selected #3888

merged 1 commit into from
Nov 9, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Nov 9, 2018

Rectify my mistake in #3849, according to discussion in #3849 (comment).

@hcho3 hcho3 requested a review from trivialfis November 9, 2018 07:21
trivialfis
trivialfis approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If things got really complicated in the future we can consider implementing a simple state machine or organize a proper mapping. It might sound exhausting but currently we can't detect wrong combination of parameters, or wrong parameter.

@hcho3
Copy link
Collaborator Author

hcho3 commented Nov 9, 2018

@trivialfis Good suggestion.

@hcho3 hcho3 merged commit be0bb7d into dmlc:master Nov 9, 2018
@hcho3 hcho3 deleted the extraneous_warning_learner branch November 9, 2018 20:30
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis