Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo's doc: Update README.MD to fix typo #4156

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

keni-chi
Copy link
Contributor

@keni-chi keni-chi commented Feb 17, 2019

I noticed "Benckmark" was used at the demo/kaggle-higgs/README.MD instead of "Benchmark".
If that was intentional then ignore this change.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 17, 2019

@trivialfis @RAMitchell I'm seeing this error lately in unit test:

[ RUN      ] GpuHist.ApplySplit
unknown file: Failure
C++ exception with description "vector::_M_range_check" thrown in the test body.

EDIT. Seeing the same error in #4155
Any idea what's going on?

@trivialfis
Copy link
Member

That's weird. Seems not deterministic. Will try looking into it.

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #4156 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4156      +/-   ##
==========================================
+ Coverage   63.37%   63.37%   +<.01%     
==========================================
  Files         131      131              
  Lines       11982    11983       +1     
==========================================
+ Hits         7593     7594       +1     
  Misses       4389     4389
Impacted Files Coverage Δ
src/tree/split_evaluator.cc 49.79% <0%> (ø) ⬆️
src/gbm/gbtree_model.h 44.82% <0%> (ø) ⬆️
src/tree/split_evaluator.h 100% <0%> (ø) ⬆️
include/xgboost/predictor.h 100% <0%> (ø) ⬆️
src/data/sparse_page_dmatrix.h 100% <0%> (ø) ⬆️
src/tree/updater_quantile_hist.h 18.05% <0%> (ø) ⬆️
src/data/simple_dmatrix.h 100% <0%> (ø) ⬆️
include/xgboost/learner.h 100% <0%> (ø) ⬆️
src/common/transform.h 88.88% <0%> (ø) ⬆️
src/common/host_device_vector.h 75% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e618af...a1e9620. Read the comment docs.

@trivialfis trivialfis merged commit 60f0535 into dmlc:master Feb 18, 2019
@trivialfis
Copy link
Member

@keni-chi Thanks!

@keni-chi keni-chi deleted the feature_doc_modify branch February 20, 2019 03:25
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants