-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Refactor Jenkins CI pipeline + migrate all Linux tests to Jenkins #4401
Conversation
@CodingCat Can you look at this? In particular, I'd like to seek your feedback to the cross-version checks, where XGBoost4J JARs are tested against JDK 8, 11, and 12. See https://xgboost-ci.net/blue/organizations/jenkins/hcho3-xgboost-ci-test/detail/refactor_jenkins/107/pipeline/203 for an example of JVM test. (Note: Spark tests are only run for JDK 8 for now) |
LGTM for jvm-packages part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CodingCat FYI, this PR is adding a dummy project named xgboost4j-tester under jvm-packages. This is needed so that I can run code from xgboost4j-example |
that's fine, we can use it for more integration test in future |
TODO: write a short doc explaining what |
defeb50
to
8d81b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what happened in sanitizer yet. But I'm hoping not to disable leak sanitizer.
@trivialfis I found the fix for leak detector: google/sanitizers#764. I need to add PTRACE capability to docker runs. |
Re-basing against the latest master to fix Windows tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's gonna be awesome. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing thanks @hcho3
Running two Spark jobs in a row resulted in #4406, so I'm disabling the second Spark integration test for now |
Will try to fix Mac CMake build issue in a follow-up PR |
Merged. Thanks everyone! |
dmlc#4401) * All Linux tests are now in Jenkins CI * Tests are now de-coupled from builds. We can now build XGBoost with one version of CUDA/JDK and test it with another version of CUDA/JDK * Builds (compilation) are significantly faster because 1) They use C5 instances with faster CPU cores; and 2) build environment setup is cached using Docker containers
See #4234 for details.
Note that builds (compilation) are significantly faster because