Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent copying data to host. #4795

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Prevent copying data to host. #4795

merged 1 commit into from
Aug 21, 2019

Conversation

trivialfis
Copy link
Member

Closes #4751 .

@trivialfis trivialfis requested review from hcho3 and RAMitchell and removed request for hcho3 August 20, 2019 03:50
@trivialfis
Copy link
Member Author

trivialfis commented Aug 20, 2019 •
edited
Loading

There are still small copyings scattered over the place. Including ColumnSampler and label_correct_ in regression obj. But the big ones are addressed.

@trivialfis trivialfis merged commit fba298f into dmlc:master Aug 21, 2019
@trivialfis trivialfis deleted the fix-configuration branch August 21, 2019 04:33
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

@hcho3 hcho3 Awaiting requested review from hcho3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU predictor crashes when training with data stored in GPU memory.
2 participants
@trivialfis @RAMitchell