[jvm-packages] Add getNumFeature method #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6075 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 12 12
Lines 3069 3069
=======================================
Hits 2410 2410
Misses 659 659 Continue to review full report at Codecov.
|
|
@hiliev some unit tests should be added |
|
LGTM, @CodingCat Could you help to review? |
hcho3
approved these changes
Sep 6, 2020
jvm-packages/xgboost4j/src/main/scala/ml/dmlc/xgboost4j/scala/Booster.scala
Outdated
Show resolved
Hide resolved
|
@hcho3 Can we merge? |
|
I made a simple change for better code style. We'll merge after tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the functionality of XGBoosterGetNumFeature accessible from Java and Scala.