Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly await async method client.wait_for_workers #8558

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Properly await async method client.wait_for_workers #8558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e219aa8
Properly await async method client.wait_for_workers
mrocklin Dec 6, 2022
bc8e135
ignore mypy error.
trivialfis Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python-package/xgboost/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ async def _get_rabit_args(
sched_addr = None

# make sure all workers are online so that we can obtain reliable scheduler_info
client.wait_for_workers(n_workers)
await client.wait_for_workers(n_workers) # type: ignore
env = await client.run_on_scheduler(
_start_tracker, n_workers, sched_addr, user_addr
)
Expand Down