-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated indentation #8
Comments
In retrospect that test does look pretty surprising. @pratapvardhan, thoughts? |
Any time you have a blank line, then a single indented line, then any number of subsequent lines with more indentation, the original indentation is wrong. eg:
will become
|
Here's a PR: #9 |
Progress on this? I'd rather depend on a real version that my fork. |
Bump? |
Sorry, I'll merge & release this next chance I get. Probably 2 days from now |
@dmnd sorry to bug you again, any chances of this happening soon? |
Sorry for the (huge) delay. Merged your PR! Thank you. |
Summary: This updates dedent to 0.7.0. Aside from being behind, 0.7.0 is also the first to have definitions on flow-typed. These will be included in the next diff. The only breaking change here is making dedent behave as it should in this case: dmnd/dedent#8 Reviewed By: matthewwithanm Differential Revision: D8022381 fbshipit-source-id: ee6da0cc8d35c82453a067d94628b61b1c010f3f
Summary: This updates dedent to 0.7.0. Aside from being behind, 0.7.0 is also the first to have definitions on flow-typed. These will be included in the next diff. The only breaking change here is making dedent behave as it should in this case: dmnd/dedent#8 Reviewed By: matthewwithanm Differential Revision: D8022381 fbshipit-source-id: ee6da0cc8d35c82453a067d94628b61b1c010f3f
Is this test actually testing the expected behaviour:
I thought this was a bug, and have a fix for it, but then there's a test for it.
I would have expected the result to be
"first\n___second\n______third"
(MD is eating up my whitespace).Let me know if it is actually a bug and I'll make a PR
The text was updated successfully, but these errors were encountered: