Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Upgrading Node to verison 18 broke builds #92

Closed
3 tasks done
dontforgit opened this issue Apr 10, 2024 · 5 comments · Fixed by #93
Closed
3 tasks done

🐛 Bug: Upgrading Node to verison 18 broke builds #92

dontforgit opened this issue Apr 10, 2024 · 5 comments · Fixed by #93
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@dontforgit
Copy link

dontforgit commented Apr 10, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

A major node version dependency should not be upgraded in a bug fix.

Actual

NPM is showing the latest version is 1.5.2, which requires Node 18. This is breaking our application since Jest 29.5.0 has this somewhere in the dependency tree only supporting Node 16.

Additional Info

It looks like that tag was removed from GitHub. A new tag that reverts functionality back to 1.5.1 should be tagged as 1.5.3.
@dontforgit dontforgit added the type: bug Something isn't working :( label Apr 10, 2024
@sconzof
Copy link

sconzof commented Apr 10, 2024 •
edited
Loading

+1 It would be greatly appreciated if you could please create a 1.5.3 release that restores version 1.5.1. Thank you!

@nikolareljin
Copy link

nikolareljin commented Apr 10, 2024 •
edited
Loading

+1 Can you please create the tag 1.5.3 for https://www.npmjs.com/package/dedent since the 1.5.2 in NPMjs breaks the installation of other dependent packages?

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 11, 2024
JoshuaKGoldberg added a commit to JoshuaKGoldberg/dedent that referenced this issue Apr 11, 2024
@JoshuaKGoldberg
fix: remove engines and provenance requirements
f104609 
Fixes dmnd#92.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 11, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Apr 11, 2024
JoshuaKGoldberg added a commit that referenced this issue Apr 11, 2024
@JoshuaKGoldberg
fix: remove engines and provenance requirements (#93)
90644fe 
## PR Checklist

- [x] Addresses an existing open issue: fixes #92
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the requirements so they don't impact users.
@JoshuaKGoldberg
Copy link
Collaborator

Sorry about that folks! I published 1.5.3 now that removes the added engines field altogether. Thanks for the quick bug reports!

@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.5.3 🎉

The release is available on:

Cheers! 📦🚀

@dontforgit
Copy link
Author

Sorry about that folks! I published 1.5.3 now that removes the added engines field altogether. Thanks for the quick bug reports!

Thank you for the quick fix @JoshuaKGoldberg !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove engines and provenance requirements JoshuaKGoldberg/dedent
4 participants
@JoshuaKGoldberg @sconzof @nikolareljin @dontforgit