Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add babel-plugin-add-module-exports #40

Merged
merged 1 commit into from
Jul 2, 2023
Merged

fix: add babel-plugin-add-module-exports #40

merged 1 commit into from
Jul 2, 2023

Conversation

JoshuaKGoldberg
Copy link
Collaborator

Fixes #39. Uses the plugin's addDefaultProperty so that both old and new behavior are preserved.

After a yarn build locally, the end of dist/dedent.js is:

module.exports = exports.default;
module.exports.default = exports.default;

@JoshuaKGoldberg JoshuaKGoldberg merged commit 517af34 into dmnd:master Jul 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the add-module-exports branch July 2, 2023 17:14
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommonJS breakage: many consumers still use dedent = require("dedent")
1 participant
@JoshuaKGoldberg