-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return data gets jumbled up on a multi write when the tags don't exist. #224
Comments
I have a fix for this. |
@dmroeder Sweet! |
I think this was the issue: Lines 435 to 436 in 95d6bc9
It should be something like:
|
This reverts a previous commit to deal with data types that were assinged a value of 0. This will have to be investigated further. Fixes #224
You mind testing the bugfix/multi-write branch when you get time? It works for me, though things weren't quite failing in the same way for me. |
Pretty much sorted, only case where it didn't work was where the tags don't exist and there is no connection to the PLC (i.e. if the IP Address is incorrect):
prints:
|
This fairly niche example isn't quite right either...
prints:
|
This reverts a previous commit to deal with data types that were assinged a value of 0. This will have to be investigated further. Fixes #224
Yeah, that is weird. The latest should fix it. |
This case is still incorrect:
prints:
|
I see, somehow, I missed that comment originally |
Okay, that one should be fixed on that branch too. I considered whether to return the value that was written or the None. I went with value intended to write because that is what would be returned on a successful write. Though I could be convinced otherwise. |
I strongly favour returning None because it would make it crystal clear that there was an issue. Thank you for your assistance. |
Sold! I'll return None. I appreciate your feedback and testing. |
Looks good to me, thanks again! |
Code
Prints:
Versions
The text was updated successfully, but these errors were encountered: