Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Requester shall use the selected version in all future communication of other requests. #48

Closed
jyao1 opened this issue Jul 21, 2021 · 2 comments · Fixed by #105
Closed

The Requester shall use the selected version in all future communication of other requests. #48

jyao1 opened this issue Jul 21, 2021 · 2 comments · Fixed by #105
Assignees
@jyao1
Labels
bug Something isn't working

Comments

@jyao1
Copy link
Member

jyao1 commented Jul 21, 2021

After GET_VERSION, the requester need decide which version is final selected and always use it.

After GET_CAPABILITY, the responder will know this is the version selected by the requester and always stick it it.

Current implementation just check all supported versions, which is too relax.
@jyao1 jyao1 self-assigned this Jul 30, 2021
@jyao1 jyao1 added the bug Something isn't working label Jul 30, 2021
@liyi77 liyi77 mentioned this issue Aug 26, 2021
Closed
@liyi77 liyi77 mentioned this issue Aug 27, 2021
Closed
liyi77 added a commit to liyi77/libspdm that referenced this issue Aug 27, 2021
@liyi77
Add version negotiation feature
5f08d2a 
Fix DMTF#48
Signed-off-by: yi1 li <yi1.li@intel.com>
liyi77 added a commit to liyi77/libspdm that referenced this issue Aug 27, 2021
@liyi77
Replace connected spdm version struct
cd09a71 
Fix DMTF#48
spdm_connection_info_t should only store one negotiated spdm version.
Signed-off-by: yi1 li <yi1.li@intel.com>
@liyi77 liyi77 mentioned this issue Aug 27, 2021
Merged
liyi77 added a commit to liyi77/libspdm that referenced this issue Aug 27, 2021
@liyi77
Add version negotiation feature
69a2759 
Fix DMTF#48
Signed-off-by: yi1 li <yi1.li@intel.com>
liyi77 added a commit to liyi77/libspdm that referenced this issue Aug 27, 2021
@liyi77
Replace connected spdm version struct
be99121 
Fix DMTF#48
spdm_connection_info_t should only store one negotiated spdm version.
Signed-off-by: yi1 li <yi1.li@intel.com>
@jyao1 jyao1 closed this as completed in #105 Sep 3, 2021
jyao1 pushed a commit that referenced this issue Sep 3, 2021
@liyi77 @jyao1
Add version negotiation feature
fda5e92 
Fix #48
Signed-off-by: yi1 li <yi1.li@intel.com>
jyao1 pushed a commit that referenced this issue Sep 3, 2021
@liyi77 @jyao1
Replace connected spdm version struct
77c3378 
Fix #48
spdm_connection_info_t should only store one negotiated spdm version.
Signed-off-by: yi1 li <yi1.li@intel.com>
@rw8896
Copy link
Contributor

rw8896 commented Oct 28, 2021

@jyao1 @liyi77

I was wondering the error handling of "After GET_CAPABILITY, the responder will know this is the version selected by the requester and always stick it it."

After the version is negotiated (either from cache or set by GET_CAPABILITIES), If requester sends a command with a version other than the negotiated one, current responder seems to ignore the error and continue to process it with the previously negotiated version.

Shouldn't the responder validate the version against the negotiated one and return error if it doesn't match?

@liyi77
Copy link
Contributor

liyi77 commented Oct 29, 2021

@rw8896
Got your idea, We can make a new ISSUE to discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyao1 jyao1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version negotiation feature liyi77/libspdm
Add negotiation of version liyi77/libspdm
3 participants
@liyi77 @jyao1 @rw8896