Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetTag is not a required field #76

Closed
rdilip42 opened this issue Apr 2, 2020 · 0 comments · Fixed by #78
Closed

AssetTag is not a required field #76

rdilip42 opened this issue Apr 2, 2020 · 0 comments · Fixed by #78

Comments

@rdilip42
Copy link

rdilip42 commented Apr 2, 2020

redfishtool systems is expecting "AssetTag" in Members list but it is not required filed actually. Due to this we are seeing script failures.

udock redfishtool -r -u -p --Secure=Always Systems list
{
"_Path": "/redfish/v1/Systems",
"Name": "Computer System Collection",
"Members@odata.count": 1,
"Members": []
}

but in Systems.py we are seeing it is looking for AssetTag and etc.

def list(self,sc,op,rft, cmdTop=False, prop=None):
rft.printVerbose(4,"{}:{}: in operation".format(rft.subcommand,sc.operation))

    # getCollection
    collName="Systems"
    rc,r,j,d=op.getCollection(sc,op, rft)
    if( rc != 0):  return(rc,r,False,None)
    #loop through the members and create the list sub-operation response
    rc,r,j,d=rft.listCollection(rft, r, d, prop="AssetTag")
    if(rc==0):
        rft.printVerbose(1," list {} Collection member info: Id, URI, AssetTag".format(collName,skip1=True, printV12=cmdTop))
    return(rc,r,j,d)

https://github.com/DMTF/Redfishtool/blob/master/redfishtool/Systems.py
In redfish systems.py code they are looking for (“Id”, “URI” and “AssetTag”).

list -- list information about the Systems collection members("Id", URI, and AssetTag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant