Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default supported measurement hash algorithm SHA_256 is missed in code #19

Closed
Zhiqiang520 opened this issue Oct 18, 2021 · 0 comments · Fixed by #21
Closed

The default supported measurement hash algorithm SHA_256 is missed in code #19

Zhiqiang520 opened this issue Oct 18, 2021 · 0 comments · Fixed by #21
Assignees
@Zhiqiang520

Comments

@Zhiqiang520
Copy link
Contributor

  1. [--meas_hash] is measurement hash algorithm. By default, SHA_512,SHA_384,SHA_256 is used.

    spdm-emu/spdm_emu/spdm_emu_common/spdm_emu.c

    Line 62 in 4e66a72

    printf(" [--meas_hash] is measurement hash algorithm. By default, SHA_512,SHA_384,SHA_256 is used.\n");

  2. but SHA_256 is missed in the following code.

    spdm-emu/spdm_emu/spdm_emu_common/key.c

    Lines 102 to 104 in 4e66a72

    uint32 m_support_measurement_hash_algo =
    SPDM_ALGORITHMS_MEASUREMENT_HASH_ALGO_TPM_ALG_SHA_512 |
    SPDM_ALGORITHMS_MEASUREMENT_HASH_ALGO_TPM_ALG_SHA_384;

  3. here also mentioned the default supported measurement hash algorithm.
    https://github.com/DMTF/spdm-emu/blob/main/doc/spdm_emu.md
Zhiqiang520 added a commit to Zhiqiang520/spdm-emu that referenced this issue Oct 21, 2021
@Zhiqiang520
Add SHA_256 as one of the default supported measurement hash algorithm.
bb69be5 
FIX: DMTF#19
@Zhiqiang520 Zhiqiang520 mentioned this issue Oct 21, 2021
Merged
Zhiqiang520 added a commit to Zhiqiang520/spdm-emu that referenced this issue Oct 21, 2021
@Zhiqiang520
Add SHA_256 as one of the default supported measurement hash algorithm.
ada2121 
FIX: DMTF#19

Signed-off-by: Zhao, Zhiqiang <zhiqiang.zhao@intel.com>
@jyao1 jyao1 closed this as completed in #21 Oct 21, 2021
jyao1 pushed a commit that referenced this issue Oct 21, 2021
@Zhiqiang520 @jyao1
Add SHA_256 as one of the default supported measurement hash algorithm.
ecabfed 
FIX: #19

Signed-off-by: Zhao, Zhiqiang <zhiqiang.zhao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zhiqiang520 Zhiqiang520

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SHA_256 as one of the default supported measurement hash algorithm. Zhiqiang520/spdm-emu
1 participant
@Zhiqiang520