add C string like quoting for many strings #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found as many of these strings as I could, I guess I've probably missed some, but it's at least enough that my app test suite is quiet, instead of scrolling with tonnes of warnings. |
|
Thank you for your work, really appreciate it. Went trough the code and added your string quoting fixes together with additional ones I found. Have not merged your pull request due to some issues it introduced with test results. If you have time, please try to test your code with latest TTP master branch commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 unicode string by default requires this to be safe. If deprecation warnings are turned on it complains a lot about these unquoted strings.