Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using schedd.transaction in PostJob #8597

Closed
belforte opened this issue Aug 8, 2024 · 1 comment
Closed

stop using schedd.transaction in PostJob #8597

belforte opened this issue Aug 8, 2024 · 1 comment

Comments

@belforte
Copy link
Member

belforte commented Aug 8, 2024

it has been deprecated
image

need to change this code

with self.schedd.transaction(htcondor.TransactionFlags.NonDurable):
for param in params:
self.schedd.edit([self.dag_jobid], param, str(params[param]))
self.schedd.edit([self.dag_jobid], 'CRAB_PostJobLastUpdate', str(time.time()))
# Once ClassAd state attributes have been updated, let HTCondor remove the job from the queue
self.schedd.edit([self.dag_jobid], "LeaveJobInQueue", classad.ExprTree("false"))
self.logger.info(" -----> Finished %s -----", msg)
self.logger.info("====== Finished to update job ClassAd.")
break

@belforte
Copy link
Member Author

belforte commented Aug 8, 2024

schedd.transaction was introduced in 48b3700
but there is no record of the reason for this choice. I suspect that we can simply remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant