Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYPI proof-of-concept #8088
PYPI proof-of-concept #8088
Changes from all commits
5f26920
639b1dc
6428e40
cfd2b13
0ba2b7e
46ff962
f8d412d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if wmcore-src is a name for python:3.8 image (L2) how can it contain /WMCore ?
Similarly, what's the purpose of giving to names to same image in Line2 and Line12 ?
Oh well...I am simply lost here, I was naively expecting all COPY and RUN to happen inside the base image, that that image is specified only at Line42. I better not try to understand more !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is like you have 3 directory:
wmcore-src
(Line 2): you copy (e.g.cp/rsync
) everything frompython:3.8
directory, created by some guy on the internet, to yourwmcore-src
, then put your own files in therebuild-data
(Line 12): same procedure, you copy everything frompython:3.8
to yourbuild-data
, this time you put another set of files in it, plus copy files fromwmcore-src
directory to this directory too.wmagent-base:pypi-20230705
to main directory, you put yet-another-set-of-files in there, plus files frombuild-data
At the end of
docker build
, the first 2 directory get discarded. The main directory, you tag it withcrabtaskworker:manual
, zip it, and upload to docker hub.