-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChildWorker module #8527
Add ChildWorker module #8527
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Jenkins results:
|
shouldn't we then move to |
I put it behind feature flags so we can easily turn it off and purge it later if it does not work. I plan to move to the TaskWorker section later if we enable it permanently. And nslaves, I can move it back to the usual TaskWorker section if you do not like it. |
Beautiful !! Thanks. Only one comment, just like you pass |
good point (about sequential test) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry Stefano, forgot to answer your question.
I do not know the good way, but now I do not need it anymore (see the comments in module doc). |
thanks for the explaining the logger situation ! |
Fix #8428
New
ChildWorker
module to spawn the child process from slave to run work() (for example,handleNewTask
in Handler.py#L153).The module can handle timeout (via SIGALARM), coredump, normal error. Then, propagate errors in form of exception back to slave, and to the caller properly.
This mode(?) is behind the feature flags
config.FeatureFlags.childWorker
, can enable it from TW config file.The TW config will have additional lines: