Support Proxy client certificate #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle not to create a new one. In addition, for temporary bundle files, it was declared as an X509Auth class variable to be automatically deleted at the end of the program.
|
Is it okay if the Python version is limited to 3.6 or higher? As far as I know, the f-string works from 3.6 or higher. |
|
@geonmo Hi Geonmo, yes, I'd say that is a fair assumption. Many CMS projects use it with Python 3.8.2. |
amaltaro
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Thank you for providing this patch, Geonmo. It looks good to me.
Valentin, to be safer, I still think further tests - with multiple scenarios - should be performed before this change gets merged. I'd suggest at least:
- on SLC7, test these changes within a test WMAgent box (using robot or service certificate)
- on SLC7, test these changes with user proxy
vkuznet
requested changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am applying for PR to deal with issue #13 .
This PR has been changed to support the processing of proxy certificates signed with the user's certificate.
When using a
nss-linked libcurl for ssl backend, it check the issuing authority of the proxy certificate and handle it even if verifypeer is applied as False.Because the proxy certificate is signed with a user certificate, the public key of the user certificate must be placed in the list of trusted certificates. For users who do not have root privileges, creating and applying a certificate bundle file is the easiest way to do this.