T0 unit tests : repack job splitting

[hufnagel]

Currently the repack job splitting has a unit test, but that test only checks that the class can be instantiated. Once the problem of setting up a Oracle test instance and using it in unit tests has been solved, we want to expand on that.

There are already placeholders for the basic checks we want to run in the unit test.

Had a chat with Simon, who suggested to write the unit tests for just the splitting algorithm, without database. It's non-trivial because the repack jobsplitting uses custom DAOs. Not sure it's worth it, given that I have to figure out a way to run with the database anyways.

[hufnagel]

hufnagel: Postponed until #2444 is fixed.

[hufnagel]

hufnagel: Please Review

[hufnagel]

hufnagel: Please Review

[DMWMBot]

mnorman: When I run this, I get the following:

[mnorman@cms-xen39 JobSplitting_t]$ python2.6 Repack_t.py

..FF.

FAIL: test02 (main.RepackTest)

Traceback (most recent call last):
File "Repack_t.py", line 253, in test02
"ERROR: Split lumis were not created."
AssertionError: ERROR: Split lumis were not created.

FAIL: test03 (main.RepackTest)

Traceback (most recent call last):
File "Repack_t.py", line 307, in test03
"ERROR: Split lumis were not created."
AssertionError: ERROR: Split lumis were not created.

---

Ran 5 tests in 52.092s

FAILED (failures=2)

I take it that this is not expected.

Printing out the splitLumis, I note that both of them are blank ([]). I don't know what causes that. Can you reproduce?

[hufnagel]

hufnagel: Fixed, also addressed the use of assert instead of self.assertEqual etc.

[DMWMBot]

mnorman: This works for me now.

[sfoulkes]

sfoulkes: (In d70c8c1) Add unit tests for repacking. Fixes #2137.

From: Dirk Hufnagel hufnagel@cern.ch
Signed-off-by: Matt Norman mnorman@fnal.gov