Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out PromptReco configuration from run/stream configuration #2723

Closed
hufnagel opened this issue Oct 27, 2011 · 4 comments
Closed

Split out PromptReco configuration from run/stream configuration #2723

hufnagel opened this issue Oct 27, 2011 · 4 comments
Assignees

Comments

@hufnagel
Copy link
Member

At the moment the RunConfig code that configures run/stream settings also does configure everything happening with PromptReco and later.

This should be factored out into settings needed immediately for run/stream handling (repacking and RAW file handling) and settings only required later when we release PromptReco for the run.

@hufnagel
Copy link
Member Author

hufnagel commented May 1, 2012

hufnagel: Did the refactoring, but for the moment still call the two configuration methods at the same time. Separating this in time will follow later.

Please review (RunConfig and Tier0Feeder)

@DMWMBot
Copy link

DMWMBot commented May 1, 2012

dballest: Both unit tests work. However I see that in the Tier0Feeder unit test the new configurePromptReco method is not called, RunConfig unit test calls it and works.

@hufnagel
Copy link
Member Author

hufnagel commented May 1, 2012

hufnagel: That's ok. The functionality is in the RunConfigAPI, therefor that unit tests calls the method. The Tier0Feeder component on the other hand currently only configures for Repack and Express, so this is not being used (yet).

@hufnagel
Copy link
Member Author

hufnagel commented May 1, 2012

hufnagel: (In 456763a) factor out reco config from run/stream config, fixes #2723

Signed-off-by: Dirk Hufnagel Dirk.Hufnagel@cern.ch

@ghost ghost assigned DMWMBot Jul 24, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants