Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LFN naming #1156

Closed
sfoulkes opened this issue Feb 24, 2011 · 12 comments
Closed

Fix LFN naming #1156

sfoulkes opened this issue Feb 24, 2011 · 12 comments
Assignees
Labels

Comments

@sfoulkes
Copy link
Contributor

The output files don't follow the CMS naming convention at https://twiki.cern.ch/twiki/bin/view/CMS/DMWMPG_Namespace . The data tier is being put before the Acquisition Era, the primary dataset is missing, etc. This needs to be fixed asap

@DMWMBot
Copy link

DMWMBot commented Feb 24, 2011

mnorman: Will that do?

@drsm79
Copy link

drsm79 commented Feb 24, 2011

metson: The LFN's should be checked against a regexp in Lexicon to make sure that there's nothing funny happening in the substitution and that the various strings conform to the expected standards (e.g. no extra / etc.), see also #943.

@sfoulkes
Copy link
Contributor Author

sfoulkes: Norman is working on 943 and will fold the lfn checks into that ticket.

@drsm79
Copy link

drsm79 commented Feb 24, 2011

metson: Sweet.

@DMWMBot
Copy link

DMWMBot commented Feb 25, 2011

mnorman: Added name change to keep Steve from getting the vapors (he's got a problem with remembering names).

@sfoulkes
Copy link
Contributor Author

sfoulkes: (In 7808797) Fix LFN naming. Fixes #1156.

From: Matt Norman mnorman@fnal.gov
Signed-off-by: Steve Foulkes sfoulkes@fnal.gov

@sfoulkes
Copy link
Contributor Author

sfoulkes: (In 11653) Fix LFN naming. Fixes #1156.

From: Matt Norman mnorman@fnal.gov
Signed-off-by: Steve Foulkes sfoulkes@fnal.gov

@drsm79
Copy link

drsm79 commented Feb 25, 2011

metson: The substitutions should be replaced by a call to Lexicon - we need to have one place where LFN's are generated and that should be Lexicon.

@DMWMBot
Copy link

DMWMBot commented Feb 26, 2011

mnorman: Why?

I could understand that if there was actually some mechanics involved in creating the LFN, but what we're doing here is joining N strings together into one string. That's not so complicated an idea that it requires a separate function, especially since it still leaves the developer in charge of figuring out which item goes where. Is there a point to us writing our own implementation of "%s/%s"?

@drsm79
Copy link

drsm79 commented Feb 26, 2011

metson: The point is to have the substitution in one place, not in N. We have had requests to slightly tweak the LFN (including block ID in it some how), that's made significantly simpler if there's only one place we need to make that change.

Also, WMAgent isn't the only tool that uses LFN's. Things like DBS should be using the same code as the stage out etc.

@DMWMBot
Copy link

DMWMBot commented Feb 26, 2011

mnorman: What are the prospects of actually having to make a series of changes to the LFN format?

And I think the difference in what it will make us do is minimal. If you're going to add information, you have to re-write the code that would call it anyway - all you're doing is just rearranging the rewrites.

Also, a different question here, is LFN naming guaranteed to be universal? Is AnalysisOps guaranteeing that all user analysis datasets will also comply with the LFN schema we've set out?

@drsm79
Copy link

drsm79 commented Feb 26, 2011

metson: Replying to [comment:12 mnorman]:

Also, a different question here, is LFN naming guaranteed to be universal? Is AnalysisOps guaranteeing that all user analysis datasets will also comply with the LFN schema we've set out?

Yes. It's a universal naming convention. The problems in the past have been that the convention hasn't been consistently applied by our applications, hence wanting this in one place...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants