Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate MSPilupeObj creation and validation #11863

Open
vkuznet opened this issue Jan 17, 2024 · 0 comments
Open

Separate MSPilupeObj creation and validation #11863

vkuznet opened this issue Jan 17, 2024 · 0 comments

Comments

@vkuznet
Copy link
Contributor

vkuznet commented Jan 17, 2024

Impact of the new feature
Current implementation of MSPilupeObj has validation step as part of object constructor. Therefore, the MSPileupObj constructor requires certain attributes, like validRSEs. This works fine when we create new MSPileup objects, but it is not required (and in fact redundant) if we updated MSPileupObj which we create of existing one. This requires to pass unnecessary parameters at constructor during update cycle.

Is your feature request related to a problem? Please describe.
This feature pop-up during implementation of partial pileup document, see #11807

Describe the solution you'd like
We should separate validation step from constructor of MSPileup object, and run it separately ONLY during createPileup MSPileup API in MSPileupData.py module.

Describe alternatives you've considered
Do nothing and keep passing parameters to MSPileupObj constructor.

Additional context
Please see https://github.com/dmwm/WMCore/pull/11807/files#r1455594348 and questions raised above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant