Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Cheetah3 to requirements_py3.txt #10491

Merged
merged 1 commit into from
May 18, 2021
Merged

added Cheetah3 to requirements_py3.txt #10491

merged 1 commit into from
May 18, 2021

Conversation

mapellidario
Copy link
Member

Related to #6460

Status

Ready

Description

Reflecting cms-sw/cmsdist#6898 in dmwm/WMCore requirements_py.txt

Is it backward compatible (if not, which system it affects?)

YES

@mapellidario mapellidario self-assigned this May 18, 2021
@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
    • 4 tests added
  • Pylint check: succeeded
  • Pylint py3k check: succeeded
    • 0 errors and warnings that should be fixed
    • 0 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11755/artifact/artifacts/PullRequestReport.html

amaltaro
amaltaro approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dario, I was definitely going to forget it!

@amaltaro amaltaro merged commit d2e6164 into dmwm:master May 18, 2021
@mapellidario mapellidario deleted the 6460-fix branch September 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaltaro amaltaro amaltaro approved these changes

Assignees

@mapellidario mapellidario

Labels
Python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapellidario @cmsdmwmbot @amaltaro