Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repack slots flag #10629

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Remove repack slots flag #10629

merged 1 commit into from
Jun 28, 2021

Conversation

germanfgv
Copy link
Contributor

@germanfgv germanfgv commented Jun 28, 2021

Fixes #10630

Status

ready

Description

Eliminates the Repack condor flag from SimpleCondorPlugin. This was tested in T0 Large scale test during Data Challenge 2021.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
    • 5 changes in unstable tests
  • Python2 Pylint check: succeeded
    • 4 warnings
    • 19 comments to review
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 4 warnings
    • 24 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 16 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12039/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python2 Pylint check: succeeded
    • 4 warnings
    • 19 comments to review
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 4 warnings
    • 24 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 16 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12041/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, German!

PS: I'm actually surprised to read that most of the CERN worker nodes have now SSD disks(!)

@amaltaro amaltaro merged commit c816d94 into dmwm:master Jun 28, 2021
@germanfgv
Copy link
Contributor Author

Changes look good to me, German!

PS: I'm actually surprised to read that most of the CERN worker nodes have now SSD disks(!)

Yes, we got the information from Ben Jones:

[bejones@aiadm00 ~]$ condor_status -const '!isUndefined(CERNDisktype)' -compact -af CERNDisktype | sort | uniq -c
141
1795 hdd
14375 ssd

(those 141 outliers are going to be some cloud things you don't run on).

You can find more details in CMSTZ-918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove T0 RequestRepackslots flag from SimpleCondorPlugin
3 participants